Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should mostly conclude step 6 in #337
This PR adds liquidity collection to the
AuctionConverter
in the new driver enabling the solvers to actually compute solutions.Following steps were needed:
LiquidityCollecting
trait (for testing purposes)/solve
(auctions are quite big)I was so far not able to get a solution which actually simulates. I will delay debugging that (if that was even caused by a bug in the new driver) to a follow up PR where I focus on logging errors with tenderly links like the current driver does it.
Test Plan
Added unit test for liquidity collection in
AuctionConverter
.manual test piping a real auction to quasimodo through the new driver
During this test
UniswapV3
liquidity was disabled because I was not sure if that might lead to problems in Quasimodo.curl "https://api.cow.fi/mainnet/api/v1/auction" > current_auction; curl -X POST -H "Content-Type: application/json" -d @./current_auction localhost:8080/api/quasimodo/solve
yielded output: