Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize components needed for auction creation in autopilot #426

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

vkgnosis
Copy link
Contributor

@vkgnosis vkgnosis commented Aug 8, 2022

This PR contains no new logic. It copies arguments and component initialization from orderbook to autopilot. Later I will clean up and deduplicate some of this back.

After this the solvable_orders module can be moved from the orderbook crate to the autopilot crate. The autopilot will store the auctions in the database and the orderbook will read them from the database.

When merging I need to make sure that staging has all the new arguments set.

Test Plan

CI

@vkgnosis vkgnosis requested a review from a team as a code owner August 8, 2022 13:10
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #426 (7aca4ea) into main (c062703) will decrease coverage by 0.56%.
The diff coverage is 0.00%.

❗ Current head 7aca4ea differs from pull request most recent head aee928e. Consider uploading reports for the commit aee928e to get more accurate results

@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   64.36%   63.80%   -0.57%     
==========================================
  Files         227      227              
  Lines       43425    43807     +382     
==========================================
  Hits        27950    27950              
- Misses      15475    15857     +382     

@vkgnosis vkgnosis enabled auto-merge (rebase) August 9, 2022 06:05
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description contains some template text but the code changes look good.

@vkgnosis vkgnosis enabled auto-merge (squash) August 9, 2022 06:17
@vkgnosis vkgnosis merged commit a8f75dd into main Aug 9, 2022
@vkgnosis vkgnosis deleted the autopilot-prepare branch August 9, 2022 06:20
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants