Refactor recent block cache metrics to macro #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of this there is now a label value that differentiates between different caches rather than sharing the same metric.
vkgnosis
force-pushed
the
block-cache-metrics
branch
from
3c2d7ed
to
e518327
Compare
Codecov Report
@@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 64.19% 64.27% +0.07%
==========================================
Files 223 223
Lines 42221 42163 -58
==========================================
- Hits 27105 27100 -5
+ Misses 15116 15063 -53 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this there is now a label value that differentiates between
different caches rather than sharing the same metric.
Test Plan
CI