Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move signature validator module into shared #406

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

vkgnosis
Copy link
Contributor

@vkgnosis vkgnosis commented Aug 3, 2022

This module is needed in orderbook and autopilot. Later I might do a fine grained refactor move some things out of shared again.

No logic change.

Test Plan

CI

@vkgnosis vkgnosis requested a review from a team as a code owner August 3, 2022 12:17
@nlordell
Copy link
Contributor

nlordell commented Aug 3, 2022

fine grained refactor move some things out of shared again.

Is there value to having a crate specifically for shared components between orderbook and api?

@vkgnosis
Copy link
Contributor Author

vkgnosis commented Aug 3, 2022

There might be. It's going to be easier to track down the dependencies when the autopilot stuff is done. I'm going to re-visit it then.

Base automatically changed from move-account-bal to main August 3, 2022 12:31
@codecov-commenter
Copy link

Codecov Report

Merging #406 (e4e8217) into main (e2da212) will decrease coverage by 0.00%.
The diff coverage is 10.52%.

❗ Current head e4e8217 differs from pull request most recent head 79e11bc. Consider uploading reports for the commit 79e11bc to get more accurate results

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   64.08%   64.07%   -0.01%     
==========================================
  Files         221      222       +1     
  Lines       41851    41848       -3     
==========================================
- Hits        26819    26816       -3     
  Misses      15032    15032              

@vkgnosis vkgnosis enabled auto-merge (rebase) August 3, 2022 12:32
@vkgnosis vkgnosis merged commit 7d3e85e into main Aug 3, 2022
@vkgnosis vkgnosis deleted the move-signature-valid branch August 3, 2022 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants