Move solver competition storing into database crate #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunce86
approved these changes
Jul 25, 2022
| @@ -141,6 +141,7 @@ mod tests { | |||
| async fn postgres_save_and_get_quote_by_id() { | |||
| let mut db = PgConnection::connect("postgresql://").await.unwrap(); | |||
| let mut db = db.begin().await.unwrap(); | |||
| crate::clear_DANGER_(&mut db).await.unwrap(); | |||
There was a problem hiding this comment.
nit: Shouldn't this function be called clear_db or similar?
There was a problem hiding this comment.
It is in the database crate so I didn't feel we needed an extra pre/postfix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
refactored tests and new test