Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e test solvable orders logic #375

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Fix e2e test solvable orders logic #375

merged 1 commit into from
Jul 20, 2022

Conversation

vkgnosis
Copy link
Contributor

When e2e tests manually update the solvable orders cache it is possible
that the result is overwritten by the automatic update which in turn
could have been initiated at an earlier point in time leading to a
recently created order being missing.

Fixes #362

@vkgnosis vkgnosis marked this pull request as ready for review July 19, 2022 12:18
@vkgnosis vkgnosis requested a review from a team as a code owner July 19, 2022 12:18
@vkgnosis vkgnosis enabled auto-merge (rebase) July 19, 2022 12:58
Copy link
Contributor

@sunce86 sunce86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

When e2e tests manually update the solvable orders cache it is possible
that the result is overwritten by the automatic update which in turn
could have been initiated at an earlier point in time leading to a
recently created order being missing.
@vkgnosis vkgnosis merged commit db6a768 into main Jul 20, 2022
@vkgnosis vkgnosis deleted the e2e-debug branch July 20, 2022 09:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random e2e test failure
2 participants