-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block number to mempool_executed logs #3200
Conversation
Which data is expected to be used in order to simulate it(apart from the block number)? An example of the reverted txs: https://aws-es.cow.fi/_dashboards/goto/6d4fcd16a939814d07fbec7d5e72660e?security_tenant=global |
The access list is not really needed for the simulation, it saves gas, but it can be simulated without it. |
Revert { | ||
tx_id: eth::TxId, | ||
block_number: BlockNo, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can be also (as data types are clear):
#[error("Mined reverted transaction: {0:?}, block: {1:?}")]
Revert(eth::TxId, eth::BlockNo),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunce86 we show this as a debug version of it. I would keep it as in the logs will say tx_id
and block_number
, IMO better than seeing only a hashed and a number without saying what it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it's gonna be BlockNo(123456789)
Description
Add block number to mempool_executed logs, so we can simulate failed submissions in order to debug the reason of the failure.