Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky e2e test #3143

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Fix flaky e2e test #3143

merged 4 commits into from
Nov 28, 2024

Conversation

squadgazzz
Copy link
Contributor

@squadgazzz squadgazzz commented Nov 28, 2024 •
edited
Loading

Fixes flaky e2e test by starting autopilot only once all the orders are created. Locally, these failures are almost impossible to reproduce since all the orders, in most cases, belong to a single auction, while this is not the case on CI.

@squadgazzz squadgazzz requested a review from a team as a code owner November 28, 2024 16:24
mstrug
mstrug approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@mstrug mstrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. However we could move the default autopilot args to one definition/or separate function, so we are not copying strings, but they are defined in one place.

@squadgazzz squadgazzz changed the title Fix flaky e2e tests Fix flaky e2e test Nov 28, 2024
@squadgazzz squadgazzz merged commit f53b2d2 into main Nov 28, 2024
11 checks passed
@squadgazzz squadgazzz deleted the fix-e2e-flaky-tests branch November 28, 2024 18:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
@sunce86
Copy link
Contributor

sunce86 commented Dec 1, 2024

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mstrug mstrug mstrug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@squadgazzz @sunce86 @mstrug