Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAPI change reminder #3138

Merged
merged 3 commits into from
Nov 28, 2024
Merged

OpenAPI change reminder #3138

merged 3 commits into from
Nov 28, 2024

Conversation

squadgazzz
Copy link
Contributor

  • Nudges author to think about backwards compatibility when openapi.yml changes.
  • Reminds to make DB migration revertable.

@squadgazzz squadgazzz requested a review from a team as a code owner November 27, 2024 19:58
m-lord-renkse
m-lord-renkse approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@m-lord-renkse m-lord-renkse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! have you tried it out?

MartinquaXD
MartinquaXD approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that a small test run for an openapi change would be nice.

.github/nitpicks.yml Outdated Show resolved Hide resolved
.github/nitpicks.yml Show resolved Hide resolved
@squadgazzz
Copy link
Contributor Author

A test run: #3139

@squadgazzz squadgazzz enabled auto-merge (squash) November 28, 2024 11:28
@squadgazzz squadgazzz merged commit 7359612 into main Nov 28, 2024
11 checks passed
@squadgazzz squadgazzz deleted the update-nitpicks-job branch November 28, 2024 11:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m-lord-renkse m-lord-renkse m-lord-renkse approved these changes

@MartinquaXD MartinquaXD MartinquaXD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@squadgazzz @MartinquaXD @m-lord-renkse