Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRIVIAL] Drop unused Balancer pool deny list config #3121

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

squadgazzz
Copy link
Contributor

@squadgazzz squadgazzz commented Nov 12, 2024

The config is not used. The following one should be used instead:

enum BalancerV2Config {
#[serde(rename_all = "kebab-case")]
Preset {
preset: BalancerV2Preset,
/// Deny listed Balancer V2 pools.
#[serde(default)]
pool_deny_list: Vec<eth::H256>,
/// The URL used to connect to balancer v2 subgraph client.
graph_url: Url,
},
#[serde(rename_all = "kebab-case")]
Manual {
/// Addresses of Balancer V2 compatible vault contract.
vault: eth::H160,
/// The weighted pool factory contract addresses.
#[serde(default)]
weighted: Vec<eth::H160>,
/// The weighted pool factory v3+ contract addresses.
#[serde(default)]
weighted_v3plus: Vec<eth::H160>,
/// The stable pool factory contract addresses.
#[serde(default)]
stable: Vec<eth::H160>,
/// The liquidity bootstrapping pool factory contract addresses.
///
/// These are weighted pools with dynamic weights for initial token
/// offerings.
#[serde(default)]
liquidity_bootstrapping: Vec<eth::H160>,
/// The composable stable pool factory contract addresses.
#[serde(default)]
composable_stable: Vec<eth::H160>,
/// Deny listed Balancer V2 pools.
#[serde(default)]
pool_deny_list: Vec<eth::H256>,
/// The URL used to connect to balancer v2 subgraph client.
graph_url: Url,
},
}

Requires https://github.com/cowprotocol/infrastructure/pull/2250 to be merged first.

@squadgazzz squadgazzz marked this pull request as ready for review November 12, 2024 18:13
@squadgazzz squadgazzz requested a review from a team as a code owner November 12, 2024 18:13
@squadgazzz squadgazzz changed the title Drop unused Balancer pool deny list config [TRIVIAL] Drop unused Balancer pool deny list config Nov 12, 2024
@squadgazzz squadgazzz enabled auto-merge (squash) November 18, 2024 10:04
@squadgazzz squadgazzz merged commit 4b8c4f7 into main Nov 18, 2024
11 checks passed
@squadgazzz squadgazzz deleted the unused-balancer-pool-deny-list-config branch November 18, 2024 10:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants