Start indexing settlement contract as its creation as latest #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-lord-renkse
force-pushed
the
start-indexing-from-settlement-contract-start-block
branch
7 times, most recently
from
3d8def0 to
4bb24f4
Compare
m-lord-renkse
force-pushed
the
start-indexing-from-settlement-contract-start-block
branch
from
4bb24f4 to
839ce25
Compare
fleupold
approved these changes
Nov 19, 2024
m-lord-renkse
deleted the
start-indexing-from-settlement-contract-start-block
branch
sunce86
reviewed
Dec 1, 2024
| @@ -11,14 +11,16 @@ impl_event_retrieving! { | |||
|
|
|||
| pub struct Indexer { | |||
| db: Postgres, | |||
| start_index: u64, | |||
There was a problem hiding this comment.
nit: could have been eth::BlockNo to make the code clearer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start indexing settlement contract as its creation as latest. Starts from index block 0 if the contract has no deployment information (e2e test cases which deploy the contracts from scratch only).
The problem is that when we add a new network, it starts indexing from block 0 until it finds the first settlement contract event. Once the first event is found, it is stored in the database. By starting from the settlement contract creation block, we start indexing in a more efficient way.