Added auction_id field to /settle and /reveal requests #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
approved these changes
Nov 11, 2024
m-lord-renkse
approved these changes
Nov 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
auction_idfield to the/settleand/revealAPI requests.This feature was requested by one of the solvers team (ref).
Changes
Updated
driverandautopilotDTOs, added code to use these new fields and added additional condition ondriverside to verify if providedsolution_idis competing in providedauction_id.Refactored
drivertests to support new fields.How to test
Added new scenario to
driver_handles_solutions_based_on_id()test which validates error on wrongauction_idspecified (success cases are already validated by other scenarios in this test).