Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move API code into orderbook crate #3104

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Move API code into orderbook crate #3104

merged 2 commits into from
Nov 5, 2024

Conversation

MartinquaXD
Copy link
Contributor

Description

First PR in a series of refactors to get the shared crate back into a reasonable shape.

Changes

Moves shared::api into the orderbook crate since that is the only place where it's needed

@MartinquaXD MartinquaXD requested a review from a team as a code owner November 5, 2024 07:28
@MartinquaXD MartinquaXD enabled auto-merge (squash) November 5, 2024 10:35
@MartinquaXD MartinquaXD merged commit 40c8526 into main Nov 5, 2024
10 of 11 checks passed
@MartinquaXD MartinquaXD deleted the move-api-code-into-orderbook branch November 5, 2024 10:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sunce86 sunce86 sunce86 approved these changes

@m-lord-renkse m-lord-renkse m-lord-renkse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinquaXD @sunce86 @m-lord-renkse