Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BalancerV2ComposableStablePoolFactoryV6 in contracts #3099

Merged

Conversation

m-lord-renkse
Copy link
Contributor

Description

Add support for BalancerV2ComposableStablePoolFactoryV6 in contracts. It is compatible with V5, so no changes are needed: https://github.com/balancer/balancer-deployments/pull/108/files#diff-8730c2b8ae6de974591d1c41121ef43dc296a98f578c960359f328e9d54afe50R3-R4

@m-lord-renkse m-lord-renkse marked this pull request as ready for review October 30, 2024 14:00
@m-lord-renkse m-lord-renkse requested a review from a team as a code owner October 30, 2024 14:00
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming the second arbitrum entry gets fixed.

crates/contracts/build.rs Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shows up weird in the github UI but when checked out the file content looks correct (identical to v5).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it right? same to me, weird :/

Copy link
Contributor

@sunce86 sunce86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-lord-renkse m-lord-renkse merged commit 516b0fe into main Oct 31, 2024
12 checks passed
@m-lord-renkse m-lord-renkse deleted the add-support-for-balancer-composable-stable-pool-factory-v6 branch October 31, 2024 08:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants