-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Base contract addresses #3098
Conversation
@@ -739,7 +815,7 @@ fn main() { | |||
.add_network_str(GOERLI, "0xE592427A0AEce92De3Edee1F18E0157C05861564") | |||
.add_network_str(SEPOLIA, "0xE592427A0AEce92De3Edee1F18E0157C05861564") | |||
.add_network_str(ARBITRUM_ONE, "0xE592427A0AEce92De3Edee1F18E0157C05861564") | |||
// Not available on Gnosis Chain | |||
// Not available on Gnosis Chain and Base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, looks like base has a UniversalRouter
that can be used for V2 and V3. Would be good to check if we can use it interchangeably.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like that:
The Universal Router codebase consists of the UniversalRouter contract, and all of its dependencies. The purpose of the UniversalRouter is to allow users to unify Uniswap ERC20 swaps (on V2 and V3) with NFT purchases across 8 marketplaces, in a single transaction.
https://github.com/Uniswap/universal-router
We can't use V2 and V3 interchangeably, but what I understand is that we can use UniversalRouter
to either use V2 or V3. So, by using the UniversalRouter
address, we should be able to access V3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to use the UniversalRouter
instead of UniswapV3SwapRouter
they need to expose the same interface (or at least the parts we are using - exactOutputSingle()
) which does not seem to be the case.
Description
Add Base contract addresses