Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Base contract addresses #3098

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Conversation

m-lord-renkse
Copy link
Contributor

Description

Add Base contract addresses

@m-lord-renkse m-lord-renkse marked this pull request as ready for review October 30, 2024 11:59
@m-lord-renkse m-lord-renkse requested a review from a team as a code owner October 30, 2024 11:59
@@ -739,7 +815,7 @@ fn main() {
.add_network_str(GOERLI, "0xE592427A0AEce92De3Edee1F18E0157C05861564")
.add_network_str(SEPOLIA, "0xE592427A0AEce92De3Edee1F18E0157C05861564")
.add_network_str(ARBITRUM_ONE, "0xE592427A0AEce92De3Edee1F18E0157C05861564")
// Not available on Gnosis Chain
// Not available on Gnosis Chain and Base
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like base has a UniversalRouter that can be used for V2 and V3. Would be good to check if we can use it interchangeably.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like that:

The Universal Router codebase consists of the UniversalRouter contract, and all of its dependencies. The purpose of the UniversalRouter is to allow users to unify Uniswap ERC20 swaps (on V2 and V3) with NFT purchases across 8 marketplaces, in a single transaction.

https://github.com/Uniswap/universal-router

We can't use V2 and V3 interchangeably, but what I understand is that we can use UniversalRouter to either use V2 or V3. So, by using the UniversalRouter address, we should be able to access V3.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to use the UniversalRouter instead of UniswapV3SwapRouter they need to expose the same interface (or at least the parts we are using - exactOutputSingle()) which does not seem to be the case.

crates/contracts/build.rs Outdated Show resolved Hide resolved
@m-lord-renkse m-lord-renkse merged commit ce91316 into main Nov 4, 2024
11 checks passed
@m-lord-renkse m-lord-renkse deleted the add-base-contract-addresses branch November 4, 2024 14:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants