[EASY] Don't report encoding errors for merged solutions #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
changed the title
m-lord-renkse
approved these changes
Oct 25, 2024
MartinquaXD
deleted the
dont-report-errors-coming-from-merged-solutions
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The majority of solutions that get discarded due to failing encoding/simulating/scoring are actually merged solutions. These solutions get merged by the driver and not by the solver. The driver does it naively so it's not really surprising that it tries to merge solutions which are incompatible (e.g. they could use the same liquidity source).
Changes
To avoid alerting on false positives the solver has no control over we now only report solutions that come directly from the solver in a non-working state (i.e. only 1 sub-solution contained).