Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASY] Bump response size limit #3080

Merged
merged 2 commits into from
Oct 23, 2024
Merged

[EASY] Bump response size limit #3080

merged 2 commits into from
Oct 23, 2024

Conversation

MartinquaXD
Copy link
Contributor

@MartinquaXD MartinquaXD commented Oct 23, 2024

Description

Since October 6th we see alerts like Failed to buffer the request body: length limit exceeded indicating that the response returned by multiple solvers (oneinch, zeroex, paraswap, balancer) is too big for the driver.
It's unclear why this suddenly started happening on a Sunday where nothing gets released or why it only seems to affect dex solvers but making the max response size configurable seems like a reasonable thing to do regardless.

Changes

  • Made drivers response size limit configurable and increased the default value by 3x.
  • Added trace log to print responses that exceed the limit to easily debug this the next time this happens (disabled by default but be temporarily enabled without restarting the pod)

How to test

e2e test covers parsing of the new config parameter

@MartinquaXD MartinquaXD requested a review from a team as a code owner October 23, 2024 06:28
@MartinquaXD MartinquaXD changed the title Bump response size limit [EASY] Bump response size limit Oct 23, 2024
Copy link
Contributor

@m-lord-renkse m-lord-renkse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have in the logs the size of the responses? did they suddenly jump or the increase was progressive? The previous default value of 10 MB seems relatively big 🤔

@MartinquaXD
Copy link
Contributor Author

No, we don't have the size of the response as metrics or logs. We stream the content in chunks and abort when we exceed the limit so we don't know what the total size would be.

@MartinquaXD MartinquaXD merged commit 11df525 into main Oct 23, 2024
11 checks passed
@MartinquaXD MartinquaXD deleted the bump-response-size-limit branch October 23, 2024 08:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants