Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playground check #3079

Merged
merged 39 commits into from
Oct 30, 2024
Merged

Playground check #3079

merged 39 commits into from
Oct 30, 2024

Conversation

mstrug
Copy link
Contributor

@mstrug mstrug commented Oct 22, 2024 •
edited
Loading

Description

New CI job added to verify if Playground is working on current code.

Changes

Added playground-check.yaml workflow file which starts Playground docker containers and runs dedicated test script: test_playground.sh. Run schedule is set to once a day or manually on chosen branch. Execution takes around 20min.

Test script tries to swap USDC for WETH tokens using Rest API. Additional calls using cast cli tool for wrapping ETH and submitting allowance. Signing is done also using cast cli tool in EIP712 scheme.

How to test

It is enough to run playground-check job.
To test locally follow the instructions to start Playground in playground/README.md file, then run playground/test_playground.sh script.

MartinquaXD
MartinquaXD reviewed Oct 23, 2024
View reviewed changes
playground/test_playground.sh Outdated Show resolved Hide resolved
playground/test_playground.sh Outdated Show resolved Hide resolved
playground/test_playground.sh Outdated Show resolved Hide resolved
mstrug and others added 20 commits October 24, 2024 22:52
@mstrug mstrug marked this pull request as ready for review October 28, 2024 23:38
@mstrug mstrug requested a review from a team as a code owner October 28, 2024 23:38
MartinquaXD
MartinquaXD approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!
Just a few nits that could be cleaned up but overall this is a very nice test for the playground.

.github/workflows/playground-check.yaml Show resolved Hide resolved
playground/test_playground.sh Outdated Show resolved Hide resolved
playground/test_playground.sh Outdated Show resolved Hide resolved
playground/test_playground.sh Outdated Show resolved Hide resolved
playground/test_playground.sh Outdated Show resolved Hide resolved
playground/test_playground.sh Outdated Show resolved Hide resolved
playground/test_playground.sh Outdated Show resolved Hide resolved
playground/test_playground.sh Outdated Show resolved Hide resolved
m-lord-renkse
m-lord-renkse approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@m-lord-renkse m-lord-renkse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mstrug mstrug merged commit 9bc0269 into main Oct 30, 2024
12 checks passed
@mstrug mstrug deleted the ci/playground-check branch October 30, 2024 22:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m-lord-renkse m-lord-renkse m-lord-renkse approved these changes

@MartinquaXD MartinquaXD MartinquaXD approved these changes

@squadgazzz squadgazzz Awaiting requested review from squadgazzz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mstrug @MartinquaXD @squadgazzz @m-lord-renkse