Index cow amms in background task #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunce86
approved these changes
Oct 22, 2024
m-lord-renkse
approved these changes
Oct 22, 2024
MartinquaXD
force-pushed
the
index-cow-amms-in-background-task
branch
from
20f0d2d
to
174c47a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently restarts on arbitrum are slow enough to cause emergency alerts. The reason is that we still don't persist indexed cow amms so we re-index everything from scratch. As a workaround until we store cow amms in the DB which makes syncing to the tip very fast after a restart I moved the cow amm indexing into a background task that will not block starting new auctions.
The effect is that as we continue to index cow amms after a restart more and more cow amms will show up in the auction.
How to test
CI and test on staging to see that restarts are fast again and cow amms eventually show up