Multiple winners e2e test #3066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunce86
added
the
E:6.2 Time to Happy Moo
MartinquaXD
approved these changes
Oct 18, 2024
Comment on lines
+22
to
+23
| max_hops: usize, | ||
| merge_solutions: bool, |
There was a problem hiding this comment.
The testing code gets more and more complex it seems. I tried to make this test happen without adding these new arguments but it seems this is not as straight forward.
Seems like the issue is that we need to have native prices which requires a TOKEN <> WETH pool. And since you need to have these pools for all traded tokens to have the order included in the auction you can't prevent a solver from using the route via WETH.
We should probably try cleaning up the e2e testing stuff some time soon. :/
squadgazzz
reviewed
Oct 18, 2024
squadgazzz
reviewed
Oct 18, 2024
squadgazzz
reviewed
Oct 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements e2e test for multiple winners per auction feature.
Verifies that:
/settlecalls are sent and two transactions are mined.How to test
Added test.