Fix metrics and observations in autopilot runloop #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunce86
added
bug
sunce86
changed the title
sunce86
changed the title
MartinquaXD
approved these changes
Oct 7, 2024
| // Report orders that were part of a non-winning solution candidate | ||
| // but only if they were part of the auction (filter out jit orders) | ||
| non_winning_orders.retain(|uid| auction_uids.contains(uid)); | ||
| super::Metrics::matched_unsettled(&winner.driver, non_winning_orders); |
There was a problem hiding this comment.
Given that we prepare for having multiple winners I'm not sure if recording the global winner still makes sense here. Ultimately it's not the global winner's responsibility to settle all possible orders.
I'm even not sure if this information is so helpful in the single winner setup.
There was a problem hiding this comment.
I wondered the same, so ended up leaving it this way as having the list of non-winning orders might still be useful to observe, although the driver itself is not that important anymore I guess. I think we can reevaluate after some time and probably remove it if not needed.
m-lord-renkse
approved these changes
Oct 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several smaller issues related to metrics in the autopilot run loop and refactors functions in preparation for #2996 (comment).
Changes
Self::is_solution_fairis now checked for every solution, not just for the global winner (fixing an oversight in PR #2996)Next step: refactor
competitionfunction from shadow and main runloop to be exactly the same and unify theParticipantstruct (currently both modes have their own version).How to test
Existing e2e tests