Include necessary data for simulations within the auction json sent to solvers #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to open a PR for the gnosis solver too. |
m-lord-renkse
force-pushed
the
2606/include-necessary-data-within-auction-json
branch
from
f62523c
to
a4aa3ed
Compare
m-lord-renkse
commented
Apr 15, 2024
m-lord-renkse
force-pushed
the
2606/include-necessary-data-within-auction-json
branch
from
a4aa3ed
to
002927c
Compare
m-lord-renkse
force-pushed
the
2606/include-necessary-data-within-auction-json
branch
13 times, most recently
from
eb3f00d
to
517d0b3
Compare
m-lord-renkse
force-pushed
the
2606/include-necessary-data-within-auction-json
branch
from
517d0b3
to
96c68f3
Compare
MartinquaXD
reviewed
Apr 16, 2024
m-lord-renkse
force-pushed
the
2606/include-necessary-data-within-auction-json
branch
3 times, most recently
from
43fad78
to
d24e8de
Compare
m-lord-renkse
force-pushed
the
2606/include-necessary-data-within-auction-json
branch
3 times, most recently
from
86a8878
to
0c00d50
Compare
m-lord-renkse
force-pushed
the
2606/include-necessary-data-within-auction-json
branch
4 times, most recently
from
71728c6
to
e226535
Compare
MartinquaXD
reviewed
Apr 19, 2024
m-lord-renkse
force-pushed
the
2606/include-necessary-data-within-auction-json
branch
3 times, most recently
from
14ecfa0
to
235d0f9
Compare
m-lord-renkse
force-pushed
the
2606/include-necessary-data-within-auction-json
branch
from
64363b5
to
b0c51db
Compare
MartinquaXD
approved these changes
Apr 23, 2024
m-lord-renkse
added a commit
that referenced
this pull request
Apr 24, 2024
…2649) # Description Remove `deny_unknown_fields` for auction order in solvers-dto. This way new changes in the payload does not break the solvers. It is needed to merge #2620 without having downtime for the solvers. # Changes Remove `deny_unknown_fields` for auction order in solvers-dto. ## How to test 1. Regression tests
m-lord-renkse
force-pushed
the
2606/include-necessary-data-within-auction-json
branch
from
b0c51db
to
44ec390
Compare
m-lord-renkse
added a commit
to gnosis/solvers
that referenced
this pull request
Apr 24, 2024
…o solvers (#18) Include necessary data for simulations within the auction json sent to solvers. Follow up for cowprotocol/services#2620
m-lord-renkse
deleted the
2606/include-necessary-data-within-auction-json
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, solvers need to use the /auction endpoint to recover missing info, such as hooks, for orders in a batch auction in order to be able to simulate their proposed solution themselves. We could instead ensure that all necessary info is included in the auction json.
Changes
Data added to the auction json:
How to test
Related Issues
Fixes #2606