Prevent orders with excessive valid to from being created #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a random thought. For specific "knowingly good" use cases of long standing orders (e.g. yearn), we could create another allow list until we have a better mechanism. |
MartinquaXD
approved these changes
May 24, 2022
This is a good suggestion. If we have the need to add more accounts that we want to let place long-standing orders, we can remove the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #200
This PR adds new restrictions for orders, they have a maximum valid
validTovalue. The default is for 3 hours in the future (the same maximum as we have in the CowSwap FE).This new restriction does not apply to liquidity orders (since they don't have the same issue with gas price quotes being WAY off). We also don't apply the restriction to pre-sign orders, since they are, arguably much riskier to abuse (because of the required transaction).
Test Plan
Added test cases testing new conditions for the order validity restrictions.