Don't pay additional tip for non revertable transactions #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are currently paying a pretty high tip for some trivial settlements that are submitted via the public mempool (since they don't carry revert risk).
While we do enforce 0 additional tip for public mempool submission, we also submit each trivial transaction via the MEVBlocker mempool strategy, which allows setting a higher tip.
If a transaction is available to a builder with both a high and a low tip, a profit maximizing builder will always chose the high tipping one.
Changes
How to test
Not really e2e testable since we cannot cover MEVBlocker behavior, but we should see cheaper settlements for internalized trades in staging