Spawn GC task from RecentBlockCache constructor #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleupold
approved these changes
Dec 1, 2023
| break; | ||
| }; | ||
| if let Err(err) = inner.update_cache_at_block(block.number).await { | ||
| tracing::warn!(?err, "filed to update cache"); |
There was a problem hiding this comment.
Suggested change
| tracing::warn!(?err, "filed to update cache"); | |
| tracing::warn!(?err, "failed to update cache"); |
|
|
||
| let inner_cloned = Arc::downgrade(&inner); | ||
| tokio::task::spawn( | ||
| async move { |
There was a problem hiding this comment.
nanonit: given the size and branch complexity of this nested task could be nice to factor it into a free method and keep new more contained.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As pointed out by @fleupold here we did not prune the cached balancer v2 liquidity.
This happened because we used the
Maintainingtrait in the past which is quite error prone. The old concept was to expose a function that does GC and have 1 centralized component call that function.In the case of balancer v2 we implemented the GC function but forget to hook it up in the
driver.Changes
The new strategy I would like to use instead of the
Maintainingtrait is that every component that requires GC simply spins up its own task that takes care of it.That way you can never forget by accident to run GC.
The specific changes in this PR are:
RecentBlockCachelogic into a privateInnerstructRecentBlockCache::new()that uses the now sharableInnertypeMaintainingtraitHow to test
All unit and e2e tests still pass