Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store quotes for limit orders #2087

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Store quotes for limit orders #2087

merged 8 commits into from
Dec 1, 2023

Conversation

sunce86
Copy link
Contributor

@sunce86 sunce86 commented Nov 27, 2023

Description

Fixes #2078

Changes

  • Limit orders are no longer skipped when the quote is determined and stored into database.

How to test

Will observe the behavior on staging to make sure the quotes are stored.

Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/shared/src/order_validation.rs Outdated Show resolved Hide resolved
crates/shared/src/order_validation.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/shared/src/order_validation.rs Outdated Show resolved Hide resolved
@sunce86 sunce86 merged commit 8fbe775 into main Dec 1, 2023
8 checks passed
@sunce86 sunce86 deleted the store-quotes branch December 1, 2023 09:50
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Store quotes for limit orders
4 participants