Disable AssetFlow rule. #2080
Merged
Disable AssetFlow rule. #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleupold
reviewed
Nov 24, 2023
There was a problem hiding this comment.
Can we fully remove all asset flow related code (I quickly checked and it doesn't look like much)?
We have in the past too many times created these temporary half-assed deletions which end up staying forever and our codebase became confusing and messy because of this.
The code is stored in version control, so putting the logic back wen we want it should be trivial.
|
I had a feeling you will suggest that 😄 |
|
fleupold
approved these changes
Nov 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During colocation tests, we noticed that some of the solutions were discarded because of this rule that does not exist for legacy driver.
We want first to make sure that all existing legacy driver features are working, before introducing new rules.