[Trivial] filter out empty solutions when quoting #2072
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are seeing a lot of WARN logs for orders that can't be quoted a la:
This is because some solvers instead of returning no solution return the "trivial" solution if they cannot solve the auciton:
Since this warning looks a bit cryptic and we already do have an error for NoSolutions, this PR makes it that we instead show
Changes
Filter out empty solutions before passing them to create an invalid quote.
How to test
Run locally, get a quote which cannot be filled, observe logs