Skip to content

Commit

Permalink
Parse /settle errors and only warn about them (#2004)
Browse files Browse the repository at this point in the history
# Description
#1999 had the unfortunate
side effect that we spammed a few
[alerts](https://cowservices.slack.com/archives/C037PB929ME/p1697812387457109)
whenever the driver was not able to settle a solution.

# Changes
We now only `warn` whenever we can't parse the success response. We
didn't introduce, expect and parse any specific error format because
eventually drivers will be run externally and maybe not all of them run
a driver compliant with the error response spec all the time.
If we simply print the parsing error we'll get all the data we can get
out of the response anyway.
  • Loading branch information
MartinquaXD authored Oct 24, 2023
1 parent 9d8d255 commit e1df668
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/autopilot/src/run_loop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ impl RunLoop {
Ok(()) => Metrics::settle_ok(driver),
Err(err) => {
Metrics::settle_err(driver, &err);
tracing::error!(?err, driver = %driver.name, "settlement failed");
tracing::warn!(?err, driver = %driver.name, "settlement failed");
}
}
}
Expand Down

0 comments on commit e1df668

Please sign in to comment.