feat(trading-sdk): set default slippage 2% for eth selling #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfetopito
requested changes
Feb 5, 2025
src/trading/utils.ts
Outdated
| return { | ||
| ...params, | ||
| sellToken: WRAPPED_NATIVE_CURRENCIES[chainId], | ||
| slippageBps: typeof params.slippageBps === 'number' ? params.slippageBps : ETH_FLOW_DEFAULT_SLIPPAGE_BPS, |
There was a problem hiding this comment.
Here users will always have 2% for EthFlow, even if they set more than that.
I would expect the minimum to be applied only if value is < than min.
There was a problem hiding this comment.
Sorry, I don't understand.
This code takes slippageBps from params and fallback to ETH_FLOW_DEFAULT_SLIPPAGE_BPS if it's not set.
There was a problem hiding this comment.
I think he means, you need MAX(slippageFromUser, ETH_FLOW_DEFAULT_SLIPPAGE_BPS[chainId])
if slippage for the network is 50 and user sets 30 --> 50
if slippage for the network is 50 and user sets 100 --> 100
Note how mainnet is 200, and GC is 50
alfetopito
approved these changes
Feb 11, 2025
anxolin
reviewed
Feb 24, 2025
| [SupportedChainId.BASE]: 50, // 0.5%, | ||
| [SupportedChainId.GNOSIS_CHAIN]: 50, // 0.5%, | ||
| [SupportedChainId.SEPOLIA]: 50, // 0.5%, | ||
| } |
There was a problem hiding this comment.
Awesome!
Just ready for dog-fooding i the feature :)
|
👍 approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eth-flow orders are special and need higher slippage (2%)
Testing
Please, use
examples/vanillaapp in order to try the SDK live (run it locally)