fix(trading-sdk): fix order amounts calculations #231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes first issue from the doc.
This change fixes both sell and buy orders.
It also fixes "Private Key example not working" issue.
Basically, I reverted this commit: 718b212
Unfortunately, I don't remember why I did this :(
But obviuosly this logic is wrong, because it adds fees + slippage twice:
swapParamsToLimitOrderParams
getOrderToSign
(getQuoteAmountsAndCosts call)I compared the result with CoW Swap and it matches 100%.
How to test that:
quoteResponseMock
from unit testapps/cowswap-frontend/src/api/cowProtocol/api.ts
in CoW SwapgetQuote()
function