Remove 1inch token list #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleupold
approved these changes
Mar 26, 2024
Pull Request Test Coverage Report for Build 8433378139Details
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1inch token list is used to decrease the number of network requests when fetching token information from the node.
The related API has been broken since a long time, so there is no actual efficiency gain from using this list.
The updated version of their token API requires an API key, which is by far not worth it for this use case.
Pruning this code also removes the very annoying warning "unable to recover token list from 1inch" that is shown on every invocation of a Hardhat command, since the list is prefetched to make execution faster.
Test Plan
Code compiles.