Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

Tooltip issue resolved #2294

Closed
wants to merge 1 commit into from
Closed

Conversation

jay1310
Copy link

@jay1310 jay1310 commented Jul 29, 2020

Description of PR
It is regarding the issue #2293 for adding tooltip on footer icons.

Fixes
To solve the issue, I have added a dependency named react-tooltip and added properties to the anchor tag in the footer component.
Now, a tooltip is being shown for each footer icon as soon as mouse is hovered on the icon.

Checklist

  • Compiles and passes lint tests
  • Properly formatted
  • Tested on desktop
  • Tested on phone

Screenshots
Screenshot (709)

@shuklaayush
Copy link
Member

Hey, we dropped dependency on react-tooltip earlier due to bundle size and other issues (see #2074). Also, I don't think we need any fancy tooltips for this. HTML title tags should suffice. Thanks!

@jay1310
Copy link
Author

jay1310 commented Jul 30, 2020

Okay. Sorry for that, but i had no idea that it had been dropped earlier.
Actually, I had tried it using title tags in the footer component elements, but it was not visually attractive, therefore, I used react-tooltip. Thank you for your response.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants