Fix stdin error on windows by using Dockerfile instead #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jocgir
requested changes
Nov 29, 2017
docker.go
Outdated
| dockerFile += fmt.Sprintln("FROM", config.GetImageName()) | ||
| dockerFile += fmt.Sprintln(config.ImageBuild) | ||
|
|
||
| tempDir, _ := ioutil.TempDir(".", "tgf-docker") |
There was a problem hiding this comment.
Should use "" instead of "."
docker.go
Outdated
| dockerFile += fmt.Sprintln(config.ImageBuild) | ||
|
|
||
| tempDir, _ := ioutil.TempDir(".", "tgf-docker") | ||
| ioutil.WriteFile(fmt.Sprintf("%s/Dockerfile", tempDir), []byte(dockerFile), 0644) |
julienduchesne
force-pushed
the
CLOUDINFRA-311
branch
from
443aa22 to
d39814f
Compare
JIRA CLOUDINFRA-311
julienduchesne
force-pushed
the
CLOUDINFRA-311
branch
from
d39814f to
cb4fa78
Compare
jocgir
approved these changes
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA CLOUDINFRA-311