Merge pull request #333 from coveooss/pr-from-v5.82.1

chore: Update from hashicorp/terraform-provider-aws (v5.82.1)

.changelog/33797.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_medialive_channel: Added missing `teletext_destination_settings`.
+```

.changelog/34263.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_lambda_invocation: Set new computed value for `result` attribute when changing `input` attribute, for lifecycle scope "CRUD"
+```

.changelog/34295.txt

@@ -0,0 +1,7 @@
+```release-note:bug
+resource/aws_secretsmanager_secret_rotation: Fix bug where `automatically_after_days` was not being set properly when `schedule_expression` had been set previously
+```
+
+```release-note:bug
+resource/aws_secretsmanager_secret_rotation: Retry rotation in case it has not yet propagated when previously an error would occur: `InvalidRequestException: A previous rotation isn't complete. That rotation will be reattempted.`
+```

.changelog/38047.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_lakeformation_permissions: Fix refreshing state so order is not considered in `permissions` and `permissions_with_grant_option` attributes
+```

.changelog/38306.txt

@@ -0,0 +1,3 @@
+```release-note:new-data-source
+aws_servicecatalogappregistry_attribute_group_associations
+```

.changelog/38600.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_lakeformation_permissions: Add support for `IAMPrincipals` principal group
+```

.changelog/39952.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+data-source/aws_acmpca_certificate_authority: Ignore `AccessDeniedException: ... is not authorized to perform: acm-pca:GetCertificateAuthorityCsr on resource: ...` errors for RAM-shared CAs
+```

.changelog/40239.txt

@@ -0,0 +1,7 @@
+```release-note:new-resource
+aws_cloudfront_vpc_origin
+```
+
+```release-note:enhancement
+resource/aws_cloudfront_distribution: Add `origin.vpc_origin_config` argument
+```

.changelog/40376.txt

@@ -0,0 +1,7 @@
+```release-note:new-resource
+aws_memorydb_multi_region_cluster
+```
+
+```release-note:enhancement
+resource/aws_memorydb_cluster: Add `multi_region_cluster_name` argument
+```

.changelog/40381.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_fsx_lustre_file_system: Add `efa_enabled` argument
+```

.changelog/40398.txt

@@ -0,0 +1,3 @@
+```release-note:new-resource
+aws_rds_cluster_snapshot_copy
+```

.changelog/40514.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_elasticache_replication_group: Prevent perpetual diff which triggers resource replacement on `at_rest_encryption_enabled` when `engine` is `valkey`.
+```

.changelog/40537.txt

@@ -0,0 +1,7 @@
+```release-note:bug
+resource/aws_s3_bucket: Destroying a bucket with `force_destroy = true` can now delete objects with non-XML-safe keys
+```
+
+```release-note:bug
+resource/aws_s3_directory_bucket: Destroying a directory bucket with `force_destroy = true` can now delete objects with non-XML-safe keys
+```

.changelog/40543.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_bedrockagent_agent: Add `agent_collaboration` attribute to configure agent collaboration role
+```

.changelog/40546.txt

@@ -0,0 +1,15 @@
+```release-note:new-resource
+aws_networkmanager_dx_gateway_attachment
+```
+
+```release-note:enhancement
+resource/aws_networkmanager_attachment_accepter: Add `edge_locations` attribute
+```
+
+```release-note:enhancement
+resource/aws_dx_gateway: Add `arn` attribute
+```
+
+```release-note:enhancement
+data-source/aws_dx_gateway: Add `arn` attribute
+```

.changelog/40550.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_lb_listener: Add `advertise_trust_store_ca_names` attribute to the `mutual_authentication` configuration block
+```

.changelog/40562.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+data-source/aws_iam_policy_document: Add plan-time validation that the `statement` `sid` is valid, including on alphanumeric characters
+```

.changelog/40566.txt

@@ -0,0 +1,7 @@
+```release-note:new-resource
+aws_api_gateway_domain_name_access_association
+```
+
+```release-note:bug
+resource/aws_api_gateway_domain_name: Correct `arn` for private custom domain names
+```

.changelog/40574.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_codeconnections_host: Mark `vpc_configuration.tls_certificate` as Optional
+```

.changelog/40579.txt

@@ -0,0 +1,9 @@
+```release-note:note
+resource/aws_resourcegroups_resource: The format of the read-only `id` attribute has changed to prevent inconsistent parsing which resulted in provider crashes under certain conditions. The new format is a comma-delimited string combining `group_arn` and `resource_arn` in their entirety. Configuarations relying on the previous format may need to be updated to continue functioning correctly.
+```
+```release-note:bug
+resource/aws_resourcegroups_resource: Fix crash when parsing certain ARN formats
+```
+```release-note:enhancement
+resource/aws_resourcegroups_resource: Add import support
+```

.changelog/40583.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+resource/aws_vpc_endpoint: Add `service_region` argument
+```
+
+```release-note:enhancement
+data-source/aws_vpc_endpoint: Add `service_region` attribute
+```

.changelog/40584.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_lakeformation_resource_lf_tag: Fix panic when resource tries to destroy a LFTag reference that does not exist
+```

.changelog/40589.txt

@@ -0,0 +1,19 @@
+```release-note:bug
+resource/aws_amplify_domain_association: Prevent permanent diff when `certificate_settings` not set.
+```
+
+```release-note:bug
+resource/aws_amplify_domain_association: Prevent `ValidationException` when setting `certificate_settings.type` to `AMPLIFY_MANAGED`.
+```
+
+```release-note:bug
+resource/aws_amplify_domain_association: Prevent "unexpected state" error when setting `certificate_settings.type` to `CUSTOM`.
+```
+
+```release-note:bug
+resource/aws_amplify_domain_association: No longer ignores changes to `certificate_settings` when updating.
+```
+
+```release-note:bug
+resource/aws_amplify_domain_association: Prevents panic in some circumstances when `certificate_settings` is not set during update.
+```

.changelog/40601.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_rds_cluster: Fix issue with waiter when modifying `allocated_storage`
+```

.changelog/40604.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_sqs_queue_redrive_allow_policy: Fix perpetual `redrive_allow_policy` diffs
+```

.changelog/40621.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+data-source/aws_licensemanager_received_license: Fix `setting entitlements: Invalid address to set: []string{"entitlements", "0", "overage"}` errors
+```

.changelog/40622.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_db_parameter_group: Support import of `name_prefix` argument
+```

.changelog/40634.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_autoscaling_group: Add `availability_zone_distribution` argument
+```

.changelog/40639.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+data-source/aws_iam_policy_document: Reverts plan-time validation for `statement` `sid`
+```

.ci/.semgrep-service-name0.yml

@@ -4330,3 +4330,33 @@ rules:
             - pattern-not-regex: "^TestAccConnect"
             - pattern-regex: ^TestAcc.*
     severity: WARNING
+  - id: connect-in-const-name
+    languages:
+      - go
+    message: Do not use "Connect" in const name inside connect package
+    paths:
+      include:
+        - internal/service/connect
+    patterns:
+      - pattern: const $NAME = ...
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)Connect"
+            - pattern-not-regex: .*uickConnect.*
+    severity: WARNING
+  - id: connect-in-var-name
+    languages:
+      - go
+    message: Do not use "Connect" in var name inside connect package
+    paths:
+      include:
+        - internal/service/connect
+    patterns:
+      - pattern: var $NAME = ...
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)Connect"
+            - pattern-not-regex: .*uickConnect.*
+    severity: WARNING

.ci/.semgrep-service-name1.yml

@@ -1,35 +1,5 @@
 # Generated by internal/generate/servicesemgrep/main.go; DO NOT EDIT.
 rules:
-  - id: connect-in-const-name
-    languages:
-      - go
-    message: Do not use "Connect" in const name inside connect package
-    paths:
-      include:
-        - internal/service/connect
-    patterns:
-      - pattern: const $NAME = ...
-      - metavariable-pattern:
-          metavariable: $NAME
-          patterns:
-            - pattern-regex: "(?i)Connect"
-            - pattern-not-regex: .*uickConnect.*
-    severity: WARNING
-  - id: connect-in-var-name
-    languages:
-      - go
-    message: Do not use "Connect" in var name inside connect package
-    paths:
-      include:
-        - internal/service/connect
-    patterns:
-      - pattern: var $NAME = ...
-      - metavariable-pattern:
-          metavariable: $NAME
-          patterns:
-            - pattern-regex: "(?i)Connect"
-            - pattern-not-regex: .*uickConnect.*
-    severity: WARNING
   - id: connectcases-in-func-name
     languages:
       - go
@@ -4322,3 +4292,61 @@ rules:
       - focus-metavariable: $NAME
       - pattern-not: func $NAME($T *testing.T)
     severity: WARNING
+  - id: iotevents-in-test-name
+    languages:
+      - go
+    message: Include "IoTEvents" in test name
+    paths:
+      include:
+        - internal/service/iotevents/*_test.go
+    patterns:
+      - pattern: func $NAME( ... )
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-not-regex: "^TestAccIoTEvents"
+            - pattern-regex: ^TestAcc.*
+    severity: WARNING
+  - id: iotevents-in-const-name
+    languages:
+      - go
+    message: Do not use "IoTEvents" in const name inside iotevents package
+    paths:
+      include:
+        - internal/service/iotevents
+    patterns:
+      - pattern: const $NAME = ...
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)IoTEvents"
+    severity: WARNING
+  - id: iotevents-in-var-name
+    languages:
+      - go
+    message: Do not use "IoTEvents" in var name inside iotevents package
+    paths:
+      include:
+        - internal/service/iotevents
+    patterns:
+      - pattern: var $NAME = ...
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)IoTEvents"
+    severity: WARNING
+  - id: ipam-in-test-name
+    languages:
+      - go
+    message: Include "IPAM" in test name
+    paths:
+      include:
+        - internal/service/ec2/ipam_*_test.go
+    patterns:
+      - pattern: func $NAME( ... )
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-not-regex: "^TestAccIPAM"
+            - pattern-regex: ^TestAcc.*
+    severity: WARNING