Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(atomic): do not augment node.d.ts #5013

Merged
merged 1 commit into from
Feb 26, 2025
Merged

chore(atomic): do not augment node.d.ts #5013

merged 1 commit into from
Feb 26, 2025

Conversation

y-lakhdar
Copy link
Contributor

Instead of augmenting node.d.ts, I created a definition file just for the custom RESOURCE_URL env var.

@y-lakhdar y-lakhdar requested a review from a team as a code owner February 26, 2025 15:04
@github-actions GitHub Actions
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 243.7 243.7 0
commerce 355.1 355.1 0
search 415 415 0
insight 406.2 406.2 0
recommendation 255.9 255.9 0
ssr 408.8 408.8 0
ssr-commerce 372.9 372.9 0

fpbrault
fpbrault approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@fpbrault fpbrault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@y-lakhdar y-lakhdar enabled auto-merge February 26, 2025 16:50
@y-lakhdar y-lakhdar added this pull request to the merge queue Feb 26, 2025
auto-merge was automatically disabled February 26, 2025 17:33

Pull Request is not mergeable

Merged via the queue into master with commit 7a80a7a Feb 26, 2025
126 checks passed
@y-lakhdar y-lakhdar deleted the KIT-3999 branch February 26, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpbrault fpbrault fpbrault approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/search

@alexprudhomme alexprudhomme Awaiting requested review from alexprudhomme alexprudhomme is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y-lakhdar @fpbrault