Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(atomic): add experimental component for follow-up questions #4729

Merged
merged 11 commits into from
Nov 29, 2024

Conversation

lbergeron
Copy link
Contributor

@lbergeron lbergeron commented Nov 26, 2024

SVCC-4341

This PR adds a new experimental component providing follow-up questions when a search query is performed. It relies on the Answer API to retrieve the questions, so the answer-configuration-id attribute has to be set on the component.

follow-up-questions

It can be added to a search interface this way:

<atomic-follow-up-question-list answer-configuration-id="YOUR_ANSWER_CONFIG_ID"></atomic-follow-up-question-list>

atomic-follow-up-question-list subscribes to the SearchBox state changes to detect when a new query is performed. When it happens, the Answer API is called to retrieve follow-up questions for the current query. The questions are then rendered by the follow-up-question-list-common and atomic-follow-up-question components.

At the experimental stage, follow-up questions are supported only for the search use case. Eventually, the request would be performed from headless and follow-up-question-list-common would be updated to make it easy to support other use cases (i.e., insight and IPX).

Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 242.6 242.6 0
commerce 347.3 347.3 0
search 413.8 413.8 0
insight 404.9 404.9 0
recommendation 254.9 254.9 0
ssr 407.3 407.3 0
ssr-commerce 362.3 362.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@lbergeron lbergeron marked this pull request as ready for review November 27, 2024 15:21
@lbergeron lbergeron requested a review from a team as a code owner November 27, 2024 15:21
@dmgauthier
Copy link
Contributor

Respect 🙏

@lbergeron lbergeron added this pull request to the merge queue Nov 29, 2024
Merged via the queue into master with commit 3d52be2 Nov 29, 2024
94 checks passed
@lbergeron lbergeron deleted the feat/SVCC-4341 branch November 29, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants