-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(atomic): add experimental component for follow-up questions #4729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
lbergeron
requested review from
olamothe,
fpbrault,
fbeaudoincoveo and
alexprudhomme
November 27, 2024 15:21
dmgauthier
reviewed
Nov 27, 2024
...omic/src/components/search/atomic-follow-up-question-list/atomic-follow-up-question-list.tsx
Show resolved
Hide resolved
dmgauthier
reviewed
Nov 27, 2024
...omic/src/components/search/atomic-follow-up-question-list/atomic-follow-up-question-list.tsx
Show resolved
Hide resolved
Respect 🙏 |
dmgauthier
approved these changes
Nov 27, 2024
lbergeron
temporarily deployed
to
PR Artifacts
November 27, 2024 19:08
— with
GitHub Actions
Inactive
fbeaudoincoveo
approved these changes
Nov 28, 2024
...omponents/common/follow-up-questions/atomic-follow-up-question/atomic-follow-up-question.tsx
Outdated
Show resolved
Hide resolved
...omic/src/components/search/atomic-follow-up-question-list/atomic-follow-up-question-list.tsx
Show resolved
Hide resolved
lbergeron
temporarily deployed
to
PR Artifacts
November 28, 2024 20:59
— with
GitHub Actions
Inactive
lbergeron
temporarily deployed
to
PR Artifacts
November 29, 2024 16:51
— with
GitHub Actions
Inactive
lbergeron
temporarily deployed
to
PR Artifacts
November 29, 2024 17:26
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVCC-4341
This PR adds a new experimental component providing follow-up questions when a search query is performed. It relies on the Answer API to retrieve the questions, so the
answer-configuration-id
attribute has to be set on the component.It can be added to a search interface this way:
atomic-follow-up-question-list
subscribes to theSearchBox
state changes to detect when a new query is performed. When it happens, the Answer API is called to retrieve follow-up questions for the current query. The questions are then rendered by thefollow-up-question-list-common
andatomic-follow-up-question
components.At the experimental stage, follow-up questions are supported only for the search use case. Eventually, the request would be performed from headless and
follow-up-question-list-common
would be updated to make it easy to support other use cases (i.e., insight and IPX).