Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): revert to nodejs 18.17.1 #3231

Merged
merged 1 commit into from
Sep 28, 2023
Merged

chore(ci): revert to nodejs 18.17.1 #3231

merged 1 commit into from
Sep 28, 2023

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Sep 28, 2023

Pin NodeJS to 18.17.1:
GitHub released a new version of the ubuntu image which include a new release of NodeJS that do have a bug.

Related: nodejs/node#49911


KIT-2786

@louis-bompart louis-bompart marked this pull request as ready for review September 28, 2023 19:40
@louis-bompart louis-bompart requested a review from a team as a code owner September 28, 2023 19:40
@louis-bompart louis-bompart changed the title 18.17.1 chore(ci): revert to nodejs 18.17.1 Sep 28, 2023
@louis-bompart louis-bompart enabled auto-merge (squash) September 28, 2023 19:41
@github-actions
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 184.7 184.7 0
commerce 273 273 0
search 354.9 354.9 0
insight 306.5 306.5 0
product-listing 297 297 0
product-recommendation 158.8 158.8 0
recommendation 198.2 198.2 0
ssr 325.5 325.5 0

@louis-bompart louis-bompart merged commit 13194ac into master Sep 28, 2023
81 of 84 checks passed
@louis-bompart louis-bompart deleted the ci-node-18.17.1 branch September 28, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants