JSUI-3159 Run CI/CD on jenkins and deploy beta tags to npm #1665
Conversation
samisayegh
requested review from
btaillon-coveo,
nrawji,
olamothe and
ThibodeauJF
as code owners
| base: 'ChromeHeadless', | ||
| flags: ['--no-sandbox'] | ||
| } | ||
| }, |
There was a problem hiding this comment.
I needed to use no-sandbox to run on the latest chrome.
samisayegh
changed the title
| } | ||
|
|
||
| sh 'set +e' | ||
| // sh 'yarn run uploadCoverage' |
There was a problem hiding this comment.
I think the issue is the same as the one here: https://stackoverflow.com/questions/41978173/grunt-karma-coverage-fails-on-jenkins-but-works-on-windows-unix
I did not see a way to configure the option in the solution. I will revisit this in the future,
Jenkinsfile
Outdated
| } | ||
|
|
||
| stage('Docs') { | ||
| sh 'if [[ "x$TAG_NAME" != "x" && $IS_PULL_REQUEST_PUSH_BUILD = false ]]; then bash ./deploy.doc.sh ; fi' |
There was a problem hiding this comment.
$IS_PULL_REQUEST_PUSH_BUILD appears to be undefined here. It's a variable I originally added in the travis file.
I think $TAG_NAME may also not exist, since it's generated by travis.
There was a problem hiding this comment.
Indeed, you are right. I will comment the line out to test the full-loop and deploy a beta package to start testing. In the meantime, I will work on this in a separate jira.
This PR runs the CI/CD steps on jenkins instead of travis. It also deploys tagged versions to npm under the
betanpm tag.I will work on the deployment pipeline steps next, to be able to promote an npm package to latest, and deploy to s3 under the correct version, and run FTs.
After this, I will look at dev s3 uploads that you added recently @btaillon.