Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-keys): +listing apikey eligibility call endpoint #889

Merged

Conversation

FelixBlaisThon
Copy link
Contributor

https://coveord.atlassian.net/browse/ADUI-10325

This PR adds the newly made call to fetch the list of missing privileges when a user is creating (from scratch or from existing) an api key from a template.

As of right now, the user has access to go through all the steps to create a template api key (or create from existing) only to get denied at the very end for missing privileges of what that template key provides. This call will make it possible to prevent even starting the process for keys that require privileges that the user does not have

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

Copy link
Contributor

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@FelixBlaisThon FelixBlaisThon added this pull request to the merge queue Dec 2, 2024
Merged via the queue into master with commit 45b9ad7 Dec 2, 2024
5 checks passed
@FelixBlaisThon FelixBlaisThon deleted the ADUI-10325-prevent-unsuccesful-api-key-creation-attempt branch December 2, 2024 17:11
Copy link

github-actions bot commented Dec 2, 2024

🎉 This PR is included in version 57.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@FelixBlaisThon FelixBlaisThon mentioned this pull request Dec 2, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants