Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to Plop v3 #573

Merged
merged 41 commits into from
Dec 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
36cfc09
refactor setup 1
ThibodeauJF Nov 25, 2021
8a929ec
finish setup
ThibodeauJF Nov 25, 2021
63b4b2d
Merge branch 'master' into CDX-669
ThibodeauJF Nov 25, 2021
25785be
update template package.json
ThibodeauJF Nov 26, 2021
a249d84
add unit test
ThibodeauJF Nov 26, 2021
8d69c39
add gitignore elements
ThibodeauJF Nov 26, 2021
f882ac4
scope jest
ThibodeauJF Nov 26, 2021
f44d24e
add packagest to wait
ThibodeauJF Nov 26, 2021
32c4db4
temp remove steps
ThibodeauJF Nov 26, 2021
f8c04fc
remove notyet
ThibodeauJF Nov 26, 2021
ab9db9a
temp move outside test folder
ThibodeauJF Nov 26, 2021
f9636b0
temp only wait for a few packages
ThibodeauJF Nov 26, 2021
8271485
remove private
ThibodeauJF Nov 26, 2021
c27ea54
add atomic specs
ThibodeauJF Nov 26, 2021
4f88094
remove hidden
ThibodeauJF Nov 26, 2021
af053c0
add debug info and change waiting for
ThibodeauJF Nov 26, 2021
fef8599
remove comments & console.log
ThibodeauJF Nov 26, 2021
34038e4
remove git test
ThibodeauJF Nov 29, 2021
eaede4e
switch app runing msg
ThibodeauJF Nov 29, 2021
60f7a81
restore all tests
ThibodeauJF Nov 29, 2021
68d9c7d
Merge branch 'master' into CDX-697
ThibodeauJF Nov 29, 2021
30b236e
add timeouts
ThibodeauJF Nov 29, 2021
5886799
add readme
ThibodeauJF Nov 29, 2021
91e326d
add to cli docs
ThibodeauJF Nov 29, 2021
8a2a66e
Merge branch 'master' into CDX-697
ThibodeauJF Nov 29, 2021
1fe528e
Apply suggestions from code review
ThibodeauJF Nov 29, 2021
e42e7d8
Merge branch 'master' into CDX-697
ThibodeauJF Nov 29, 2021
e893a00
Apply suggestions from code review
ThibodeauJF Nov 29, 2021
ef84585
Merge branch 'master' into CDX-697
ThibodeauJF Nov 29, 2021
e24ba68
Merge branch 'master' into CDX-697
y-lakhdar Nov 30, 2021
f0d6be1
Update packages/cli/src/commands/ui/create/atomic.ts
ThibodeauJF Nov 30, 2021
c06759d
Merge branch 'master' into CDX-697
louis-bompart Nov 30, 2021
b50e42d
temp: comment out killAllProcesses
ThibodeauJF Nov 30, 2021
a6c7c70
Revert "temp: comment out killAllProcesses"
ThibodeauJF Nov 30, 2021
47a511d
roll back plop
ThibodeauJF Nov 30, 2021
0edd673
Merge branch 'master' into CDX-697
ThibodeauJF Dec 1, 2021
dfb1cab
bump to plop 3
ThibodeauJF Dec 1, 2021
3ea23e9
migrate project to compile modules
ThibodeauJF Dec 1, 2021
fc765d5
Merge branch 'master' into CDX-716
ThibodeauJF Dec 1, 2021
226763c
Merge branch 'master' into CDX-716
louis-bompart Dec 1, 2021
3894bea
reinstall plop 3?
ThibodeauJF Dec 1, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/create-atomic/.prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
CHANGELOG.md

package-lock.json
lib
29 changes: 29 additions & 0 deletions packages/create-atomic/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
#!/usr/bin/env node
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need the shebang? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just copied from their docs too

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious abt it, because shebang does not work on windows soo...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good thing to keep https://stackoverflow.com/a/33510581

This way, maybe when i install npm i -g @coveo/create-atomic and then run create-atomic myproject it will invoke node correctly 🤷 I haven't tested, just thinking out loud

import path from 'node:path';
import minimist from 'minimist';
import {Plop, run} from 'plop';

const args = process.argv.slice(2);
const argv = minimist(args);

import {dirname} from 'node:path';
import {fileURLToPath} from 'node:url';
louis-bompart marked this conversation as resolved.
Show resolved Hide resolved

const __dirname = dirname(fileURLToPath(import.meta.url));

Plop.prepare(
{
cwd: argv.cwd,
configPath: path.join(__dirname, 'lib/plopfile.js'),
preload: argv.preload || [],
completion: argv.completion,
},
(env) =>
Plop.execute(env, (env) => {
const options = {
...env,
dest: process.cwd(),
};
return run(options, undefined, true);
})
);
20 changes: 0 additions & 20 deletions packages/create-atomic/index.mjs

This file was deleted.

Loading