-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to Plop v3 #573
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
36cfc09
refactor setup 1
ThibodeauJF 8a929ec
finish setup
ThibodeauJF 63b4b2d
Merge branch 'master' into CDX-669
ThibodeauJF 25785be
update template package.json
ThibodeauJF a249d84
add unit test
ThibodeauJF 8d69c39
add gitignore elements
ThibodeauJF f882ac4
scope jest
ThibodeauJF f44d24e
add packagest to wait
ThibodeauJF 32c4db4
temp remove steps
ThibodeauJF f8c04fc
remove notyet
ThibodeauJF ab9db9a
temp move outside test folder
ThibodeauJF f9636b0
temp only wait for a few packages
ThibodeauJF 8271485
remove private
ThibodeauJF c27ea54
add atomic specs
ThibodeauJF 4f88094
remove hidden
ThibodeauJF af053c0
add debug info and change waiting for
ThibodeauJF fef8599
remove comments & console.log
ThibodeauJF 34038e4
remove git test
ThibodeauJF eaede4e
switch app runing msg
ThibodeauJF 60f7a81
restore all tests
ThibodeauJF 68d9c7d
Merge branch 'master' into CDX-697
ThibodeauJF 30b236e
add timeouts
ThibodeauJF 5886799
add readme
ThibodeauJF 91e326d
add to cli docs
ThibodeauJF 8a2a66e
Merge branch 'master' into CDX-697
ThibodeauJF 1fe528e
Apply suggestions from code review
ThibodeauJF e42e7d8
Merge branch 'master' into CDX-697
ThibodeauJF e893a00
Apply suggestions from code review
ThibodeauJF ef84585
Merge branch 'master' into CDX-697
ThibodeauJF e24ba68
Merge branch 'master' into CDX-697
y-lakhdar f0d6be1
Update packages/cli/src/commands/ui/create/atomic.ts
ThibodeauJF c06759d
Merge branch 'master' into CDX-697
louis-bompart b50e42d
temp: comment out killAllProcesses
ThibodeauJF a6c7c70
Revert "temp: comment out killAllProcesses"
ThibodeauJF 47a511d
roll back plop
ThibodeauJF 0edd673
Merge branch 'master' into CDX-697
ThibodeauJF dfb1cab
bump to plop 3
ThibodeauJF 3ea23e9
migrate project to compile modules
ThibodeauJF fc765d5
Merge branch 'master' into CDX-716
ThibodeauJF 226763c
Merge branch 'master' into CDX-716
louis-bompart 3894bea
reinstall plop 3?
ThibodeauJF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,4 @@ | |
CHANGELOG.md | ||
|
||
package-lock.json | ||
lib |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
#!/usr/bin/env node | ||
import path from 'node:path'; | ||
import minimist from 'minimist'; | ||
import {Plop, run} from 'plop'; | ||
|
||
const args = process.argv.slice(2); | ||
const argv = minimist(args); | ||
|
||
import {dirname} from 'node:path'; | ||
import {fileURLToPath} from 'node:url'; | ||
louis-bompart marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
const __dirname = dirname(fileURLToPath(import.meta.url)); | ||
|
||
Plop.prepare( | ||
{ | ||
cwd: argv.cwd, | ||
configPath: path.join(__dirname, 'lib/plopfile.js'), | ||
preload: argv.preload || [], | ||
completion: argv.completion, | ||
}, | ||
(env) => | ||
Plop.execute(env, (env) => { | ||
const options = { | ||
...env, | ||
dest: process.cwd(), | ||
}; | ||
return run(options, undefined, true); | ||
}) | ||
); |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need the shebang? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just copied from their docs too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious abt it, because shebang does not work on windows soo...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good thing to keep https://stackoverflow.com/a/33510581
This way, maybe when i install
npm i -g @coveo/create-atomic
and then runcreate-atomic myproject
it will invoke node correctly 🤷 I haven't tested, just thinking out loud