-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue): .eslintrc blocks user from commiting #224
Merged
+295
−50
Merged
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4b79969
remove unecessary eslint
y-lakhdar 2580660
fix lint error
y-lakhdar 3fedb14
add missing deps
y-lakhdar 93c62d8
do not lint scripts folder
y-lakhdar 43039b2
test commit in E2E tests
y-lakhdar 6cad469
forgot to change the waitUntil last time
y-lakhdar e1dec2c
I messed up
y-lakhdar af0a3a7
lock
y-lakhdar 7b33b9b
better type
y-lakhdar ec4235e
update commit test
y-lakhdar 9d2da6e
fix E2E tests
y-lakhdar 6671767
Merge branch 'master' into CDX-320-copy
louis-bompart af00b63
Merge branch 'master' into CDX-320-copy
louis-bompart 543b01f
Merge branch 'master' into CDX-320-copy
y-lakhdar 755e13a
rename misc.ts to git.ts
y-lakhdar 87ab303
Merge branch 'master' into CDX-320-copy
y-lakhdar 924ded9
Merge branch 'master' into CDX-320-copy
louis-bompart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
import {ProcessManager} from './processManager'; | ||
import {DoCallback} from './terminal/do'; | ||
import {Terminal} from './terminal/terminal'; | ||
|
||
export const commitProject = async ( | ||
processManager: ProcessManager, | ||
pathToRepo: string, | ||
projectName: string, | ||
errorCallback: DoCallback | ||
) => { | ||
const gitAddTerminal = new Terminal( | ||
'git', | ||
['add', '.'], | ||
{cwd: pathToRepo}, | ||
processManager, | ||
`add-${projectName}` | ||
); | ||
|
||
await gitAddTerminal.when('exit').on('process').do().once(); | ||
|
||
const gitCommitTerminal = new Terminal( | ||
'git', | ||
['commit', '-m', '"e2e first commit"'], | ||
{cwd: pathToRepo}, | ||
processManager, | ||
`commit-${projectName}` | ||
); | ||
|
||
const gitCommitExitCondition = gitCommitTerminal | ||
.when('exit') | ||
.on('process') | ||
.do() | ||
.once(); | ||
|
||
await gitCommitTerminal | ||
.when(/✖ \d+ problems \(\d+ errors, \d+ warnings\)/) | ||
.on('stderr') | ||
.do(errorCallback) | ||
.until(gitCommitExitCondition); | ||
}; | ||
|
||
export const undoCommit = async ( | ||
processManager: ProcessManager, | ||
pathToRepo: string, | ||
projectName: string | ||
) => { | ||
const gitTerminal = new Terminal( | ||
'git', | ||
['reset', 'HEAD~'], | ||
{cwd: pathToRepo}, | ||
processManager, | ||
`undo-${projectName}` | ||
); | ||
|
||
await gitTerminal.when('exit').on('process').do().once(); | ||
}; |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
"env": { | ||
"es6": true, | ||
"node": true, | ||
"jest": true | ||
}, | ||
|
||
"parser": "@typescript-eslint/parser", | ||
"parserOptions": { | ||
"ecmaVersion": 2020, | ||
"sourceType": "module" | ||
}, | ||
"plugins": ["@typescript-eslint"], | ||
"extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended"], | ||
"root": true | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename the file git.ts
misc
it's a large net :PI know us developer, we're a lazy bunch and we'll end up dropping everything in there 😂 (or maybe it's just me 🤷 )