fix(vue): .eslintrc blocks user from commiting #217
Conversation
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
| { | ||
| "extends": "../../.eslintrc", | ||
| "rules": { | ||
| "node/no-unpublished-import": ["off"] |
There was a problem hiding this comment.
This rule should not be applied in this package. Since the search token server folder is entirely copied into ui projects (react, vue, angular), all its dependancies should be listed in the package.json
| @@ -1,6 +0,0 @@ | |||
| { | |||
| "extends": "../../.eslintrc", | |||
There was a problem hiding this comment.
this line breaks point to an invalid path once added to a ui project (react, angular, vue)
packages/search-token-server/app.ts
Outdated
| @@ -7,7 +7,7 @@ const app = express(); | |||
|
|
|||
| app.use(express.json()); | |||
|
|
|||
| app.get<{}, any, {token: string}>( | |||
| app.get<Record<string, never>, any, {token: string}>( | |||
There was a problem hiding this comment.
Maybe: Record<string, unknown> ?
There was a problem hiding this comment.
any would work, but not unknown because of this condition: Type 'unknown' is not assignable to type 'string'.
There was a problem hiding this comment.
Why does this need to change?
| dotenv: '^9.0.2', | ||
| 'fs-extra': '^10.0.0', |
There was a problem hiding this comment.
That's doesn't make sense IMO for a vue project to have those dependency (even concurrently actually) as dependencies . As dev-dependency, sure.
There was a problem hiding this comment.
It's because the generated project depends on these 2 packages.
Currently we were lucky because these packages are available though other packages, hence why it never failed.
packages/search-token-server/app.ts
Outdated
| @@ -7,7 +7,7 @@ const app = express(); | |||
|
|
|||
| app.use(express.json()); | |||
|
|
|||
| app.get<{}, any, {token: string}>( | |||
| app.get<Record<string, never>, any, {token: string}>( | |||
There was a problem hiding this comment.
Why does this need to change?
Proposed changes
Removed
.eslintrcfile fromsearch-token-serverpackage as it does not have any additional effect. Furthermore, theextendsproperty in that eslint file was pointing to an invalid path once added to a ui project.The
/serverfolder will be linted based on the project configuration (root eslint file)Testing
E2E tests to ensure the project can be commited without the
lint-stagedhook to fail.CDX-320