Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): use getPackageVersion for create-atomic-component-project #1293

Merged
merged 5 commits into from
May 1, 2023

Conversation

louis-bompart
Copy link
Collaborator

Proposed changes

Same as #1292 for another package.

Testing

Same as #1292, but with lib

  • UT
  • Manual

@louis-bompart louis-bompart requested a review from a team as a code owner April 21, 2023 17:20
@louis-bompart louis-bompart requested review from olamothe, y-lakhdar and btaillon-coveo and removed request for a team April 21, 2023 17:20
@github-actions
Copy link
Contributor

Thanks for your contribution @louis-bompart !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@louis-bompart louis-bompart merged commit b045bfe into master May 1, 2023
@louis-bompart louis-bompart deleted the fix/CDX-1433 branch May 1, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants