Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(atomic): use the initializer version from CLI #1292

Merged
merged 2 commits into from
Apr 21, 2023
Merged

fix(atomic): use the initializer version from CLI #1292

merged 2 commits into from
Apr 21, 2023

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Apr 21, 2023 •
edited
Loading

Proposed changes

We were trying to always resolves on latest, which would can causes breaking changes in the CLI if we're doing breaking change in one of the initializer. This ensure we use the version from the CLI.

Testing

  • Unit Tests:
  • Manual Tests:

@louis-bompart louis-bompart requested a review from a team as a code owner April 21, 2023 15:11
@louis-bompart louis-bompart requested review from olamothe, y-lakhdar and mrrajamanickam-coveo and removed request for a team April 21, 2023 15:11
@github-actions
Copy link
Contributor

Thanks for your contribution @louis-bompart !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

y-lakhdar
y-lakhdar approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@y-lakhdar y-lakhdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@louis-bompart louis-bompart changed the title feat(atomic): use the initializer version from CLI fix(atomic): use the initializer version from CLI Apr 21, 2023
@louis-bompart louis-bompart added this to the ACCD GA milestone Apr 21, 2023
@louis-bompart louis-bompart merged commit 339925b into master Apr 21, 2023
@louis-bompart louis-bompart deleted the fix/use-proper-initializer-v branch April 21, 2023 16:07
@louis-bompart louis-bompart mentioned this pull request Apr 21, 2023
Merged
louis-bompart added a commit that referenced this pull request May 1, 2023
@louis-bompart
fix(cli): use getPackageVersion for create-atomic-component-project (#…
b045bfe 
…1293)

<!-- For Coveo Employees only. Fill this section.

CDX-1433

-->

## Proposed changes

Same as #1292 for another package.

## Testing
Same as #1292, but with lib

- UT
- Manual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-lakhdar y-lakhdar y-lakhdar approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@mrrajamanickam-coveo mrrajamanickam-coveo Awaiting requested review from mrrajamanickam-coveo mrrajamanickam-coveo is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ACCD GA
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-bompart @y-lakhdar