feat!: secrets support #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
commented
Jul 22, 2024
brooksmtownsend
force-pushed
the
feat/secrets-support
branch
from
742cf13 to
ce023f4
Compare
brooksmtownsend
commented
Jul 23, 2024
brooksmtownsend
force-pushed
the
feat/secrets-support
branch
2 times, most recently
from
5676bfd to
ac92a96
Compare
|
@ritesh089 |
brooksmtownsend
force-pushed
the
feat/secrets-support
branch
from
ac92a96 to
066fbd0
Compare
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
feat/secrets-support
branch
from
066fbd0 to
af01043
Compare
ritesh089
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the latest golang provider-sdk and takes care of adding secrets support for the password to connect to the couchbase cluster, and some refactors. This is marked as a draft as wasmCloud 1.1 isn't quite released yet, and that's the version that adds support for secrets.
The code itself here is complete and verified working, however I'd like to hold on merging until wasmCloud 1.1 is released and a published version of the secrets-nats-kv binary is out.
Blocked on wasmCloud/provider-sdk-go#24