Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate CBGT for DCP sharding - issue #922 #1060

Merged

Conversation

tleyden
Copy link
Contributor

@tleyden tleyden commented Aug 13, 2015

No description provided.

}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reuse our bucket.getDcpAuthHandler() here to do the username="" handling?

@adamcfraser
Copy link
Collaborator

Looks good to me - just a few minor items/questions.

@tleyden
Copy link
Contributor Author

tleyden commented Aug 13, 2015

@adamcfraser I made the changes, one of which required a fairly intensive refactor to move the SequenceClock into the base package.

I made the SyncSequenceClock.Clock field exported, since it was being accessed directly from kv_change_index.go:

// Returns the stable sequence clock for the index
func (k *kvChangeIndex) getStableClock() base.SequenceClock {
    return k.stableSequence.Clock
}

We could approach this differently, it felt a bit kludgy .. maybe keep it unexported and add an ExportClock() method?

Currently left as separate commits for easier viewing, will squash before merge.

@tleyden tleyden force-pushed the feature/distributed_index_issue_922 branch from c29857b to daacd4a Compare August 13, 2015 23:43
@tleyden tleyden force-pushed the feature/distributed_index_issue_922 branch from daacd4a to 59b33d3 Compare August 14, 2015 00:08
@tleyden
Copy link
Contributor Author

tleyden commented Aug 14, 2015

adamcfraser added a commit that referenced this pull request Aug 14, 2015
…ue_922

Integrate CBGT for DCP sharding - issue #922
@adamcfraser adamcfraser merged commit a5cd5c7 into feature/distributed_index Aug 14, 2015
@ajres ajres deleted the feature/distributed_index_issue_922 branch March 9, 2017 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants