Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silent failure if sync function maps a document to a channel with an invalid name #28

Closed
ghost opened this issue Mar 6, 2013 · 1 comment
Closed

Silent failure if sync function maps a document to a channel with an invalid name #28

ghost opened this issue Mar 6, 2013 · 1 comment

Comments

@ghost
Copy link

ghost commented Mar 6, 2013

I tried to map a document to the following channel name:

sha1-+92hjqzhtl7AxLfTQ1ATpIxEDtQ=

This contains characters that are not allowed in channel names.

The document does not get mapped to the channel, but the sync function fails silently with no error being written to the console.
@snej snej closed this as completed in 33e7dba Mar 8, 2013
@snej
Copy link
Contributor

snej commented Mar 8, 2013

Maybe we should allow "+" and "=" in channels, since SHA digests seem like a useful thing to use in a name...

snej added a commit that referenced this issue Mar 8, 2013
@snej
Make "+" and "=" legal in channel names
145e2e8 
They can both appear in base64 strings, and it seems reasonable for
someone to want to use a base64'd string as a channel name (i.e. a
digest.) See #28.
@ghost ghost mentioned this issue Nov 6, 2013
Closed
@paulharter paulharter mentioned this issue May 22, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@snej