Add New Node Locator - Round Robin #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcrn
force-pushed
the
enh/round-robin-locator
branch
from
a50290f to
79e7543
Compare
Adds a new round-robin based node locator. A round-robin node locator is useful for a couple of usecases: * Read-only applications that want to round-robin across nodes to spread load across memcached instances. * Applications that are pointing to mcrouter endpoints vs. memcached endpoints. mcrouter is a memcached compliant protocol router for scaling memcached (see https://github.com/facebook/mcrouter). Only supported for FailureMode.Cancel and FailureMode.Retry.
amcrn
force-pushed
the
enh/round-robin-locator
branch
from
79e7543 to
c91c9ab
Compare
|
Review at http://review.couchbase.org/#/c/91955/ |
theonajim
reviewed
Jun 30, 2018
| @@ -357,6 +357,15 @@ public NodeLocator createLocator(List<MemcachedNode> nodes) { | |||
| return new ArrayModNodeLocator(nodes, getHashAlg()); | |||
| case CONSISTENT: | |||
| return new KetamaNodeLocator(nodes, getHashAlg()); | |||
| case ROUND_ROBIN: | |||
| if (getFailureMode() != FailureMode.Cancel | |||
There was a problem hiding this comment.
@amcrn what is the reason for excluding Redistribute FailureMode ? RoundRobin seems like a good fit for Redistribute as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new round-robin based node locator. A round-robin node locator
is useful for a couple of usecases:
spread load across memcached instances.
endpoints. mcrouter is a memcached compliant protocol router for
scaling memcached (see https://github.com/facebook/mcrouter).
Only supported for FailureMode.Cancel and FailureMode.Retry.