Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep TOC fade up in desktop mode #2120

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Keep TOC fade up in desktop mode #2120

merged 1 commit into from
Dec 15, 2024

Conversation

cotes2020
Copy link
Owner

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description

In desktop mode, the randomness of the script execution order in the browser may cause the fade-up animation of the TOC to be lost.

no-fade-up.mov

@cotes2020 cotes2020 merged commit e0c3faf into hotfix/7.2.3 Dec 15, 2024
6 checks passed
@cotes2020 cotes2020 deleted the keep-toc-fade-up branch December 15, 2024 06:51
github-actions bot pushed a commit that referenced this pull request Dec 15, 2024
## [7.2.3](v7.2.2...v7.2.3) (2024-12-15)

### Bug Fixes

* refreshing mermaid theme may fail ([#2113](#2113)) ([2f00d41](2f00d41))
* **ui:** gap between TOC entries is inconsistent ([#2119](#2119)) ([1b4e318](1b4e318))
* **ui:** slow script loading hides TOC fade-up effect in desktop ([#2120](#2120)) ([e0c3faf](e0c3faf))
Copy link

🎉 This PR is included in version 7.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included or resolved in the release label Dec 15, 2024
jwsung91 added a commit to jwsung91/jwsung91.github.io that referenced this pull request Feb 10, 2025
* fix(i18n): correct fr-FR translations (cotes2020#1949)

Co-authored-by: Denis Jean <[email protected]>

* refactor: replace deprecated meta element

Replace `apple-mobile-web-app-capable` with `mobile-web-app-capable`

* fix(pwa): site baseurl not passed to `app.js` (cotes2020#1955)

* build(dev-deps): bump 7 dependencies versions

* chore(release): 7.1.1

## [7.1.1](cotes2020/jekyll-theme-chirpy@v7.1.0...v7.1.1) (2024-09-23)

### Bug Fixes

* **i18n:** correct fr-FR translations ([cotes2020#1949](cotes2020#1949)) ([367262e](cotes2020@367262e))
* **pwa:** site baseurl not passed to `app.js` ([cotes2020#1955](cotes2020#1955)) ([5a63244](cotes2020@5a63244))

* chore: remove `h1` element from site title (cotes2020#1960)

* fix: pagination error when pinned posts exceed the page size (cotes2020#1965)

* chore(i18n): update hungarian translation (cotes2020#1976)

* feat: show toc on mobile screens (cotes2020#1964)

* chore: close toc-popup gracefully with Esc key (cotes2020#1990)

* refactor: improve toc popup module

* refactor: reduce duplicate scss

* refactor: simplify sidebar animation

* ci: block invalid pull requests (cotes2020#2010)

* ci: skip test for invalid PRs (cotes2020#2013)

* ci: improve workflow triggers (cotes2020#2017)

- Unchain commit-lint and CI
  - Even if a commit does not meet the CI path filter, it still needs to lint the commit message.
- Unchain PR filter and CI
  - The CI workflow needs to be triggered when the commits in a pull request are modified.
- Allow manual publishing
  - Sometimes `semantic-release` will error out due to commit messages referencing discussions, but this does not affect the final RubyGems/GitHub Release. In such cases, manual triggering of the publish process is needed to complete the remaining publishing steps.

* chore: improve feed interoperability (cotes2020#2024)

* build(deps): update `wdm` gem version for compatibility (cotes2020#2028)

* chore: change stale label to `inactive`

* ci: reduce unnecessary pr-filter runs (cotes2020#2033)

- Checking the repository of the PR is more effective than checking the label to identify bot-initiated PRs
- This change also allows more flexible PR body definitions for developers with write access to the repository

* perf: speed up page rendering and jekyll build process (cotes2020#2034)

- Ensure inline scripts execute after the DOM has fully loaded.
- Use Rollup to bundle the theme-mode and Mermaid scripts, reducing the number of Jekyll include snippets.

* ci: avoid repeated runs of stylelint (cotes2020#2057)

* perf: modular sass architecture (cotes2020#2052)

- Modularized the Sass architecture to enhance code maintainability and reduce the output file size
- Replaced deprecated `@import` with `@use` / `@forward`

* build(deps-dev): upgrade dependencies

Close cotes2020#2058

* build(deps): update dependencies version

* feat: support vertical scrolling for toc in desktop mode (cotes2020#2064)

* chore(release): 7.2.0

## [7.2.0](cotes2020/jekyll-theme-chirpy@v7.1.1...v7.2.0) (2024-11-28)

### Features

* show toc on mobile screens ([cotes2020#1964](cotes2020#1964)) ([8a064a5](cotes2020@8a064a5))
* support vertical scrolling for toc in desktop mode ([cotes2020#2064](cotes2020#2064)) ([5265b03](cotes2020@5265b03))

### Bug Fixes

* pagination error when pinned posts exceed the page size ([cotes2020#1965](cotes2020#1965)) ([93f616b](cotes2020@93f616b))

### Improvements

* modular sass architecture ([cotes2020#2052](cotes2020#2052)) ([35c794c](cotes2020@35c794c))
* speed up page rendering and jekyll build process ([cotes2020#2034](cotes2020#2034)) ([65f960c](cotes2020@65f960c))

* fix: ensure pageviews are fetched after DOM is loaded (cotes2020#2071)

* build: correct the js rollup watch path (cotes2020#2074)

1. Correct the rollup watch path
2. Avoid registering watch listeners redundantly across multiple tasks

* fix: correct the import condition for theme script (cotes2020#2075)

* style: add indentation to js code

* fix(toc): resume fade up animation in desktop mode (cotes2020#2085)

* refactor: reduce the height of the TOC bottom overlay in desktop mode

* fix(build): exclude `purgecss.js` from output files (cotes2020#2090)

* chore(release): 7.2.1

## [7.2.1](cotes2020/jekyll-theme-chirpy@v7.2.0...v7.2.1) (2024-12-05)

### Bug Fixes

* **build:** exclude `purgecss.js` from output files ([cotes2020#2090](cotes2020#2090)) ([976e1a1](cotes2020@976e1a1))
* correct the import condition for theme script ([cotes2020#2075](cotes2020#2075)) ([a16aa7d](cotes2020@a16aa7d))
* ensure pageviews are fetched after DOM is loaded ([cotes2020#2071](cotes2020#2071)) ([b4019f3](cotes2020@b4019f3))
* **toc:** resume fade up animation in desktop mode ([cotes2020#2085](cotes2020#2085)) ([8280adb](cotes2020@8280adb))

* fix: js files in subdirectories are excluded from the site output (cotes2020#2101)

* chore(release): 7.2.2

## [7.2.2](cotes2020/jekyll-theme-chirpy@v7.2.1...v7.2.2) (2024-12-06)

### Bug Fixes

* js files in subdirectories are excluded from the site output ([cotes2020#2101](cotes2020#2101)) ([f55cc31](cotes2020@f55cc31))

* fix: refreshing mermaid theme may fail (cotes2020#2113)

* fix(ui): gap between TOC entries is inconsistent (cotes2020#2119)

In desktop mode, H2 and the first sub-level H3 in the TOC are too close.

* fix(ui): slow script loading hides TOC fade-up effect in desktop (cotes2020#2120)

* chore(release): 7.2.3

## [7.2.3](cotes2020/jekyll-theme-chirpy@v7.2.2...v7.2.3) (2024-12-15)

### Bug Fixes

* refreshing mermaid theme may fail ([cotes2020#2113](cotes2020#2113)) ([2f00d41](cotes2020@2f00d41))
* **ui:** gap between TOC entries is inconsistent ([cotes2020#2119](cotes2020#2119)) ([1b4e318](cotes2020@1b4e318))
* **ui:** slow script loading hides TOC fade-up effect in desktop ([cotes2020#2120](cotes2020#2120)) ([e0c3faf](cotes2020@e0c3faf))

* fix: toc not visible when switching from mobile to desktop mode (cotes2020#2139)

* docs: update the setting name for the comments

* fix(ui): left borderline of TOC is notched (cotes2020#2140)

* chore(release): 7.2.4

## [7.2.4](cotes2020/jekyll-theme-chirpy@v7.2.3...v7.2.4) (2024-12-21)

### Bug Fixes

* toc not visible when switching from mobile to desktop mode ([cotes2020#2139](cotes2020#2139)) ([32051da](cotes2020@32051da))
* **ui:** left borderline of TOC is notched ([cotes2020#2140](cotes2020#2140)) ([8a4d0bc](cotes2020@8a4d0bc))

---------

Co-authored-by: denis-games <[email protected]>
Co-authored-by: Denis Jean <[email protected]>
Co-authored-by: Cotes Chung <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Co-authored-by: Alexander Fuks <[email protected]>
Co-authored-by: Bence Boros <[email protected]>
Co-authored-by: Supreeth Mysore Venkatesh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included or resolved in the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant